From acefe34f4c23bba129978e50914888cda4c9c26e Mon Sep 17 00:00:00 2001 From: Alexis Montoison Date: Fri, 22 Sep 2023 18:27:16 -0500 Subject: [PATCH 1/2] Fix the issue with the adjoint in JOSS --- paper/paper.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/paper/paper.md b/paper/paper.md index dbe005373..7660aff58 100644 --- a/paper/paper.md +++ b/paper/paper.md @@ -210,8 +210,10 @@ if CUDA.functional() # Solve Py = x function ldiv_ic0!(P, x, y, z) - ldiv!(z, LowerTriangular(P), x) # Forward substitution with L - ldiv!(y, LowerTriangular(P)', z) # Backward substitution with Lᴴ + L = LowerTriangular(P) + Lᴴ = adjoint(L) + ldiv!(z, L, x) # Forward substitution with L + ldiv!(y, Lᴴ, z) # Backward substitution with Lᴴ return y end From 96c2d322d502496843f023d272a9c48dd59beff8 Mon Sep 17 00:00:00 2001 From: Alexis Montoison Date: Fri, 22 Sep 2023 18:40:54 -0500 Subject: [PATCH 2/2] Update example2.jl --- .buildkite/pipeline.yml | 14 -------------- paper/example2/example2.jl | 6 ++++-- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 9b7115316..1da644982 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -26,17 +26,3 @@ steps: Pkg.instantiate() include("paper/example2/example2.jl")' timeout_in_minutes: 30 - - - label: "CPUs -- StaticArrays.jl" - plugins: - - JuliaCI/julia#v1: - version: 1.9 - agents: - queue: "juliaecosystem" - command: | - julia --color=yes --project -e ' - using Pkg - Pkg.add("StaticArrays") - Pkg.instantiate() - include("test/test_extensions.jl")' - timeout_in_minutes: 30 diff --git a/paper/example2/example2.jl b/paper/example2/example2.jl index 78c622cc9..d1458e006 100644 --- a/paper/example2/example2.jl +++ b/paper/example2/example2.jl @@ -32,8 +32,10 @@ if CUDA.functional() # Solve Py = x function ldiv_ic0!(P, x, y, z) - ldiv!(z, LowerTriangular(P), x) # Forward substitution with L - ldiv!(y, LowerTriangular(P)', z) # Backward substitution with Lᴴ + L = LowerTriangular(P) + Lᴴ = adjoint(L) + ldiv!(z, L, x) # Forward substitution with L + ldiv!(y, Lᴴ, z) # Backward substitution with Lᴴ return y end