-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for positive semidefinite matrices #25
Comments
What about having |
Yes, that's nicest because it incorporates reality into specification. |
This is fixed for the general
Is this now officially supported? |
|
Reviving this issue :) Would you be open to a PR adding a We have some private code that defines a struct PSDMat{T<:Real,S<:AbstractMatrix} <: AbstractPDMat{T}
dim::Int
mat::S
chol::CholeskyPivoted{T, S}
function PSDMat{T,S}(d::Int, m::AbstractMatrix{T}, c::CholeskyPivoted{T, S}) where {T, S}
return new{T, S}(d, m, c)
end
end We could also consider the type hierarchy here. e.g.
|
there's now a |
This is the sister issue of JuliaStats/Distributions.jl/issues/366 about normal distributions with degenerated covariance matrix. On implementation would be a famility of
AbstractPSDMat
's . The question is if this should also contain the concrete types now in theAbstractPDMat
hierarchy. There are two natural choices of matrix factors, Cholesky with pivoting and LDL' decomposition, available form base respective from LAPACK.The text was updated successfully, but these errors were encountered: