Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work without stdlib SparseArrays.jl #163

Closed
wants to merge 1 commit into from

Conversation

inkydragon
Copy link
Contributor

People could build a julia without SparseArrays.jl by setting the flag USE_GPL_LIBS=0.

xref: JuliaLang/julia#53211

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68869af) 97.01% compared to head (b63f738) 96.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   97.01%   96.99%   -0.02%     
==========================================
  Files           2        2              
  Lines         435      433       -2     
==========================================
- Hits          422      420       -2     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitboy16
Copy link

Is there anything else to do on this PR? Thanks

@inkydragon
Copy link
Contributor Author

inkydragon commented Apr 25, 2024

@gitboy16

Is there anything else to do on this PR?

There is no explicit use of functions from GPL solver modules (umfpack, cholmod, spqr) in ext/SparseArraysExt.jl.

Maybe we don't need this pr.
Waiting for #163.

See also: JuliaLang/julia#54240

@inkydragon inkydragon marked this pull request as draft April 25, 2024 02:56
@ViralBShah
Copy link
Contributor

This seems like it should be ok to merge.

@inkydragon
Copy link
Contributor Author

There is no explicit use of functions from GPL solver modules (umfpack, cholmod, spqr) in ext/SparseArraysExt.jl.

I've tested this package with julia + USE_GPL_LIBS=0, all tests passed.
So we don't need this pr.

@inkydragon inkydragon closed this Oct 26, 2024
@inkydragon inkydragon deleted the ci-nogpl branch October 26, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants