Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PallHaraldsson
Copy link
Contributor

[skip ci]

[skip ci]
@PallHaraldsson
Copy link
Contributor Author

I saw a missing period, but I mainly added a PR do add a question about the doc:

This is especially a problem because the built-in Regex support in Julia incorrectly passes a flag saying that the argument has already been checked and is a valid UTF-8 sequence. Skipping that check in PCRE2 does make regex matching much faster, however it leaves you open to attacks if your are using regex on unchecked string input.

By attack, what do you mean, a security issue? Which kind, only a (denial-of-service or) information leakage?

Your type fixes it, then the type is validated UTF-8 (not even WTF-8 or other variant allowed?), and that flag is ok. If not for the default String, then you can validate manually, and it would also be ok. Or skip the flag and not validate, and also ok, just slower?

Another thing, do you have a type that autodetects? We want to take in UTF-8 for sure, but e.g. UTF-16 with the same type, i.e. detect it, and convert to UTF-8 as you read in the data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant