Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binomial of two symbolics no longer works on 1.10 #1028

Closed
isaacsas opened this issue Dec 29, 2023 · 2 comments · Fixed by #1029
Closed

binomial of two symbolics no longer works on 1.10 #1028

isaacsas opened this issue Dec 29, 2023 · 2 comments · Fixed by #1029

Comments

@isaacsas
Copy link
Contributor

isaacsas commented Dec 29, 2023

This previously worked (and is used in Catalyst for jump process models):

using ModelingToolkit
@parameters a
@variables t A(t)

# still works
binomial(A, 2*a^2)

# no longer works, but is used internally in Catalyst for example:
binomial(Symbolics.value(A), Symbolics.value(2*a^2))
@ChrisRackauckas
Copy link
Member

What if you change @register_symbolic Base.binomial(n, k)::Int true [Integer] to @register_symbolic Base.binomial(n, k)::Int true [Integer, Real]?

@isaacsas
Copy link
Contributor Author

I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants