Resolve Symbolics.Num - ForwardDiff.Dual ambiguities #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1036 +/- ##
===========================================
- Coverage 77.54% 19.28% -58.26%
===========================================
Files 30 31 +1
Lines 3429 3427 -2
===========================================
- Hits 2659 661 -1998
- Misses 770 2766 +1996 ☔ View full report in Codecov by Sentry. |
|
Looks, good, though just needs some test fixes https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/7438325797/job/20241004954?pr=1036#step:7:650 |
|
Thanks @ChrisRackauckas for checking! I updated the tests, should work better now. I also removed the fma method definitions which I thought I had already deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at resolving #1032.
The easiest way to resolve the issue seems to be to copy the relevant method definitions from ForwardDiff, which is what is done in this PR.
Unfortunately this introduces a lot of code duplication. An alternative approach would be to convert the method definition loops in https://github.com/JuliaDiff/ForwardDiff.jl/blob/master/src/dual.jl into functions that take a list of the ambiguous types as argument. However, this requires more changes to ForwardDiff in order to prevent existing methods from getting overwritten (e.g. here).
Let me know if you'd have any suggestions for this PR and I'll accommodate them.