Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support similarterm for arrayop #1095

Merged

Conversation

AayushSabharwal
Copy link
Contributor

@AayushSabharwal AayushSabharwal commented Mar 19, 2024

This is required in MTK to be able to generate functions for expressions like

@variables x[1:3] p[1:3, 1:3]
expr = bar(x, 3p)

Where bar is a @register_array_symbolic function

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.38%. Comparing base (79c4e92) to head (58b9066).
Report is 116 commits behind head on master.

Files Patch % Lines
src/arrays.jl 90.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   77.07%   76.38%   -0.69%     
==========================================
  Files          32       34       +2     
  Lines        3533     3621      +88     
==========================================
+ Hits         2723     2766      +43     
- Misses        810      855      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 1c42985 into JuliaSymbolics:master Mar 19, 2024
8 of 11 checks passed
@AayushSabharwal AayushSabharwal deleted the as/similarterm-arrayop branch March 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants