Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for typed function symbolics #1270

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

AayushSabharwal
Copy link
Contributor

Draft while the other PRs in SciML/ModelingToolkit.jl#2910 are written, so that the entire thing can be tested together.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (8cb25a8) to head (7902377).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/variable.jl 87.87% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1270       +/-   ##
===========================================
+ Coverage   30.06%   80.81%   +50.74%     
===========================================
  Files          47       47               
  Lines        4576     4728      +152     
===========================================
+ Hits         1376     3821     +2445     
+ Misses       3200      907     -2293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review September 17, 2024 06:09
@ChrisRackauckas ChrisRackauckas merged commit 50495b7 into JuliaSymbolics:master Sep 18, 2024
10 of 11 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fntype branch September 19, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants