feat: support passing arrays of Symbolic to registered functions
#1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1307 +/- ##
===========================================
+ Coverage 30.06% 78.91% +48.84%
===========================================
Files 47 47
Lines 4576 4691 +115
===========================================
+ Hits 1376 3702 +2326
+ Misses 3200 989 -2211 ☔ View full report in Codecov by Sentry. |
Comment on lines
-125
to
+128
| Ts = (Ts..., # _arr_type_fn(:(Symbolics.SymbolicUtils.Symbolic{<:$eT})), | ||
| Ts = (Ts..., _arr_type_fn(:(Symbolics.SymbolicUtils.Symbolic{<:$eT})), | ||
| _arr_type_fn(wrapper_type(eT))) | ||
| # else | ||
| # Ts = (Ts..., _arr_type_fn(:(Symbolics.SymbolicUtils.Symbolic{<:$eT}))) | ||
| else | ||
| Ts = (Ts..., _arr_type_fn(:(Symbolics.SymbolicUtils.Symbolic{<:$eT}))) |
There was a problem hiding this comment.
I'm pretty sure I disabled it temporarily in #1197 because of the issues with this (and the AbstractArray{Num}) dispatch for registered Base functions, but forgot to uncomment it once it was resolved.
5 tasks
ChrisRackauckas
merged commit 024a774
into
JuliaSymbolics:master
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.