Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iteration limit for fixpoint_sub #1321

Merged

Conversation

AayushSabharwal
Copy link
Contributor

No description provided.

@AayushSabharwal
Copy link
Contributor Author

Should this throw a warning?

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (e036266) to head (0ad4f81).
Report is 22 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1321       +/-   ##
===========================================
+ Coverage    3.80%   78.95%   +75.15%     
===========================================
  Files          47       47               
  Lines        4602     4700       +98     
===========================================
+ Hits          175     3711     +3536     
+ Misses       4427      989     -3438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 0e49be6 into JuliaSymbolics:master Oct 25, 2024
11 of 12 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fixpoint-sub-limit branch October 25, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants