Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Groebner extension, partially fix ordering #1324

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

sumiya11
Copy link
Contributor

@sumiya11 sumiya11 commented Oct 25, 2024

Addresses #1323.

using Symbolics, Groebner
@variables t S(t) R(t);
groebner_basis([-12 + 5S, 2 + 5R], ordering=Lex(S, R)); # tres bien

The following still does not work:

groebner_basis([-12 + 5S, 2 + 5R], ordering=Lex(S, R, t));

It would be reasonable if it worked. This case would better be handled on Symbolics side when converting expressions to DynamicPolynomials. Groebner does not know about extra variables such as t.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (e036266) to head (093b273).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1324       +/-   ##
===========================================
+ Coverage    3.80%   78.98%   +75.18%     
===========================================
  Files          47       47               
  Lines        4602     4707      +105     
===========================================
+ Hits          175     3718     +3543     
+ Misses       4427      989     -3438     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit dad7414 into JuliaSymbolics:master Oct 26, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants