Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix symbolic_type for unwrapped array symbolics #1346

Merged

Conversation

AayushSabharwal
Copy link
Contributor

@AayushSabharwal AayushSabharwal commented Nov 5, 2024

I am very surprised this went unnoticed until now

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (3e31a75) to head (a5dfae8).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/variable.jl 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1346       +/-   ##
===========================================
+ Coverage    6.69%   78.02%   +71.33%     
===========================================
  Files          47       50        +3     
  Lines        4618     4860      +242     
===========================================
+ Hits          309     3792     +3483     
+ Misses       4309     1068     -3241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 756b014 into JuliaSymbolics:master Nov 5, 2024
9 of 12 checks passed
@AayushSabharwal AayushSabharwal deleted the as/symbolic-type branch November 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants