Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix latexify_recipes.jl for real values of type Complex #1375

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

karlwessel
Copy link
Contributor

This fixes latexify for Complex symbolic values with no imaginary part.

A Complex value with no imaginary part isreal but is not comparable, but the real part is.

A `Complex` value with no imaginary part `isreal` but is not comparable, but the real part is.
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (6202fa4) to head (91b5dd9).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1375       +/-   ##
===========================================
+ Coverage    3.95%   79.21%   +75.25%     
===========================================
  Files          51       51               
  Lines        4824     4913       +89     
===========================================
+ Hits          191     3892     +3701     
+ Misses       4633     1021     -3612     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlwessel karlwessel marked this pull request as draft November 26, 2024 15:20
@karlwessel karlwessel closed this Nov 27, 2024
@karlwessel karlwessel deleted the patch-1 branch November 27, 2024 05:48
@karlwessel karlwessel restored the patch-1 branch November 27, 2024 05:49
@karlwessel karlwessel reopened this Nov 27, 2024
@karlwessel karlwessel marked this pull request as ready for review November 27, 2024 05:52
@ChrisRackauckas ChrisRackauckas merged commit fdce599 into JuliaSymbolics:master Dec 1, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants