Assume unknown functions are non-linear in hessian_sparsity
#1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
===========================================
+ Coverage 3.95% 79.68% +75.72%
===========================================
Files 51 51
Lines 4824 4908 +84
===========================================
+ Hits 191 3911 +3720
+ Misses 4633 997 -3636 ☔ View full report in Codecov by Sentry. |
ChrisRackauckas
merged commit 74756eb
into
JuliaSymbolics:master
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into issues similar to #749, #643, #555 etc. with
isaffine/islinear/hessian_sparsityrepeatedly.In this PR I propose to assume that functions with unknown linearity are non-linear. This seems to be a safe default that does not report any incorrect structural zeros but would at most error on the other side (missing structural zeros).
Fixes #555.
Fixes #847.
Fixes #790.
Fixes #749.