Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array registration #964

Merged
merged 13 commits into from
Dec 11, 2023
Merged

Array registration #964

merged 13 commits into from
Dec 11, 2023

Conversation

shashi
Copy link
Member

@shashi shashi commented Sep 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #964 (e3e3354) into master (60d26bb) will increase coverage by 68.85%.
Report is 12 commits behind head on master.
The diff coverage is 55.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master     JuliaLang/julia#964       +/-   ##
===========================================
+ Coverage    8.35%   77.21%   +68.85%     
===========================================
  Files          26       26               
  Lines        3267     3353       +86     
===========================================
+ Hits          273     2589     +2316     
+ Misses       2994      764     -2230     
Files Changed Coverage Δ
src/register.jl 58.33% <48.71%> (-5.77%) ⬇️
src/arrays.jl 75.55% <50.00%> (+63.92%) ⬆️
src/array-lib.jl 78.12% <100.00%> (+78.12%) ⬆️
src/diff.jl 85.42% <100.00%> (+85.08%) ⬆️
src/wrapper-types.jl 93.82% <100.00%> (+6.15%) ⬆️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shashi shashi changed the title reuse code from @wrapped in @register_symbolic Array registration Sep 21, 2023
@ufechner7
Copy link

Might fix JuliaLang/LinearAlgebra.jl#1045

@ChrisRackauckas ChrisRackauckas merged commit 634b485 into master Dec 11, 2023
12 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the s/reg branch December 11, 2023 22:47
@ChrisRackauckas
Copy link
Member

@jverzani Can you look into the SymPy failures?

@ChrisRackauckas
Copy link
Member

Thanks @shashi for seeing this through!

@jverzani
Copy link
Contributor

@jverzani Can you look into the SymPy failures?

This should be addressed with jverzani/SymPyCore.jl#34 Thanks for bringing it to my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants