Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: MethodError: no method matching div(::PolyForm{Real}, ::Rational{Int64}, ::RoundingMode{:ToZero}) coming from simplify_fractions` #968

Closed
ranocha opened this issue Sep 7, 2023 · 1 comment · Fixed by JuliaSymbolics/SymbolicUtils.jl#550

Comments

@ranocha
Copy link
Contributor

ranocha commented Sep 7, 2023

I got this error in CI at ranocha/BSeries.jl#160. The code used to work with earlier versions of Symbolics.jl and its dependencies. A kind of MWE is

julia> using Pkg; Pkg.activate(temp = true); Pkg.add("Symbolics")
...
  [0c5d862f] + Symbolics v5.5.3

julia> using Symbolics

julia> simplify_fractions((u1 * u2 + (1//2) * u1) / (2 * u1))
ERROR: MethodError: no method matching div(::PolyForm{Real}, ::Rational{Int64}, ::RoundingMode{:ToZero})
...
Stacktrace:
  [1] div(a::PolyForm{Real}, b::Rational{Int64})
    @ Base ./div.jl:47
  [2] rm_gcds(ns::Vector{PolyForm{Real}}, ds::Vector{Any})
    @ SymbolicUtils ~/.julia/packages/SymbolicUtils/YVse6/src/polyform.jl:537
  [3] simplify_div(d::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils ~/.julia/packages/SymbolicUtils/YVse6/src/polyform.jl:275
  [4] (::SymbolicUtils.var"#sdiv#133")(a::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils ~/.julia/packages/SymbolicUtils/YVse6/src/polyform.jl:328
  [5] call_composed
    @ ./operators.jl:1034 [inlined]
  [6] (::ComposedFunction{SymbolicUtils.var"#sdiv#133", typeof(quick_cancel)})(x::SymbolicUtils.BasicSymbolic{Real}; kw::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Base ./operators.jl:1031
  [7] (::ComposedFunction{SymbolicUtils.var"#sdiv#133", typeof(quick_cancel)})(x::SymbolicUtils.BasicSymbolic{Real})
    @ Base ./operators.jl:1031
  [8] (::SymbolicUtils.Rewriters.Walk{:post, ComposedFunction{SymbolicUtils.var"#sdiv#133", typeof(quick_cancel)}, typeof(SymbolicUtils.frac_similarterm), false})(x::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils.Rewriters ~/.julia/packages/SymbolicUtils/YVse6/src/rewriters.jl:200
  [9] simplify_fractions(x::SymbolicUtils.BasicSymbolic{Real}; polyform::Bool)
    @ SymbolicUtils ~/.julia/packages/SymbolicUtils/YVse6/src/polyform.jl:330
 [10] simplify_fractions(x::SymbolicUtils.BasicSymbolic{Real})
    @ SymbolicUtils ~/.julia/packages/SymbolicUtils/YVse6/src/polyform.jl:322
 [11] simplify_fractions(n::Num; kw::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Symbolics ~/.julia/packages/Symbolics/rvztO/src/Symbolics.jl:147
 [12] simplify_fractions(n::Num)
    @ Symbolics ~/.julia/packages/Symbolics/rvztO/src/Symbolics.jl:147
 [13] top-level scope
    @ REPL[5]:1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants