properly support offset indices #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Oct 8, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 77.87% 78.03% +0.16%
==========================================
Files 27 27
Lines 3371 3378 +7
==========================================
+ Hits 2625 2636 +11
+ Misses 746 742 -4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
simeonschaub
force-pushed
the
offset-idx
branch
from
f8a0a57 to
a1034b4
Compare
|
Ah, nvm! I missed 2993aa6, should be unrelated as well |
This comment was marked as outdated.
This comment was marked as outdated.
simeonschaub
force-pushed
the
offset-idx
branch
from
5c7078e to
678b9a9
Compare
|
Ok, once tests pass this should be good to go |
Also improves `summary(::ArrayOp)` for more helpful `BoundsError`s
simeonschaub
force-pushed
the
offset-idx
branch
from
678b9a9 to
b81e67d
Compare
ChrisRackauckas
merged commit e4b06dc
into
JuliaSymbolics:master
12 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior for offset indices doesn't seem to be actually useful and is quite inconsistent. If declared as
@variables k[0:3],kat first glance seems to just be1:4, i.e.k[0]throws aBoundsErrorandk[4]is valid, butaxescan in some cases tell a different story:This PR fixes these cases by properly respecting the offsets, so
kis now indexed 0 through 3 as expected. There might still be buggy behavior in other places that don't properly handle offset indices, but this at least fixes the basic cases. Unfortunately I don't know if people are relying on the current buggy behavior, so this might need to be taken into consideration