Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the LuxCore extension to Lux to support recursively_nillify #1266

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

SebastianM-C
Copy link
Contributor

@SebastianM-C SebastianM-C commented Sep 7, 2024

In order to support the new LuxCore.outputsize, we need NilSizePropagation.recursively_nillify(x) to work, but that's defined on AbstractArray{<:Real}.

The problem is that vector variables are unwrapped to a SymbolicUtils.BasicSymbolic{Vector{Real}}, which is not an AbstractArray. See SciML/ModelingToolkitNeuralNets.jl#39 (comment)

I'm not sure if we need any other dispatch besides this. Also, I'm not sure if changing the extension like this can cause any issues for users that update the package. I can test this some more.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (47cfd60) to head (22b5c9d).
Report is 98 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1266       +/-   ##
===========================================
+ Coverage    8.30%   80.31%   +72.00%     
===========================================
  Files          46       47        +1     
  Lines        4549     4634       +85     
===========================================
+ Hits          378     3722     +3344     
+ Misses       4171      912     -3259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianM-C SebastianM-C changed the title refactor: change the extension to Lux to support recursively_nillify Change the LuxCore extension to Lux to support recursively_nillify Sep 7, 2024
@ChrisRackauckas ChrisRackauckas merged commit 6d797ef into JuliaSymbolics:master Sep 7, 2024
11 checks passed
@SebastianM-C SebastianM-C deleted the lux branch September 7, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants