Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Styles of Frames do not get updated #8

Open
uliluckas opened this issue Jan 19, 2022 · 3 comments
Open

Color Styles of Frames do not get updated #8

uliluckas opened this issue Jan 19, 2022 · 3 comments
Assignees

Comments

@uliluckas
Copy link

If your node hierarchy starts with a frame with a themed color sytle, the color style of the theme does not get updates if you chnage theme.

How to reproduce:

  • Create Color Styles Day/Background, Day/Foreground, Night/Background, Night/Foreground
  • Start with a frame with color style Day/Background
  • Add some elements with some color styles Day/Foreground, to the frame
  • Add 2 themes, "Day" and "Night"
  • Select the frame
  • Change Theme to Night
  • Observe all elements changing to Night, except the frame at the root of the hierarchy
@uliluckas
Copy link
Author

Seems to work after hitting the reload button in the lower right corner of the plugin windows.

@JulianGaibler
Copy link
Owner

Hi! Thanks for creating an issue!

Some context: Atlas is generating a map for which style belongs to which theme in order to analyze the selection and make the actual swap. This generated map gets created when you start the plugin and automatically rebuilds if you make changes inside the plugin. If you add new styles or change their names in Figma, the map is outdated and needs to be rebuilt. That's what the reload button is for.

Based on your STR (thanks for that!) I'd assume that's what happened here: The colors of the frame got added later and were not included in the map, so it is expected behavior, but...

...I can see that writing a ~80 words explainer here means that this mechanism is not very intuitive. I'll take a look if this map really needs to be cached or if it can just get freshly generated when necessary.

@JulianGaibler JulianGaibler self-assigned this Jan 20, 2022
@uliluckas
Copy link
Author

Hi Julian,
thanks for the feedback. For me it is solved for now but great if you can prevent others from running in the same pit.

Uli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants