Utilities.GetUnixTime() leads to System.MissingMethodException

[maxisoft]

Hello,

Using latest pre-release ASF-win-x64.zip V5.2.7.1 and https://github.com/maxisoft/ASFFreeGames makes asf program crash due to System.MissingMethodException (maxisoft/ASFFreeGames#2).

The root cause is that the asf method ArchiSteamFarm.Core.Utilities.GetUnixTime() got trimmed out in the release.

see #2602 (comment)

---

I've made a closed (as it's a plugin related and technical issue) issue #2601 with more details.

Regards

[Rudokhvist]

Well, even though I do agree that trimming of this method is strange, rule of thumb is "if you want to use custom plugins, always get ASF-generic". Using os-specific asf "flavours" guaranteed to cause troubles,if not now - then later.

[JustArchi]

It's not trimming, the signature was changed, so the function his plugin references no longer physically exists.

[maxisoft]

I agree with you about the use of ASF-generic.
Meanwhile I guess most users don't use this version.
I'm trying to write my plugin to target the most used version (as long as i've time and energy to do so).

[JustArchi]

You do not need to use generic in regards to this problem.

[maxisoft]

It's not trimming, the signature was changed, so the function his plugin references no longer physically exists.

Indeed. I didn't saw it at first because I was reading local asf git changelog (which point to latest release tag not pre)

[Rudokhvist]

Meanwhile I guess most users don't use this version.

Most users also don't use plugins, so that's not a problem. When making plugin I always assume that user will be on generic ASF, and that's what I always tell people who order plugin development from me. Even if this case is not connected to generic, I would still recommend switching to it to avoid further issues.

[Abrynos]

Steam time was recently rewritten to use ulong values instead of uint. Check out this change for reference.

[maxisoft]

Oh this is probably the cause of the issue.

My code is referencing ArchiSteamFarm @ d087aac stable release using the uint GetUnixTime() version while latest pre-release use long GetUnixTime() internally

I fixed it in my plugin by inlining the call.

[JustArchi]

I fixed it in my plugin by inlining the call.

You should use the same method, but account for it being ulong now instead of uint as before. But of course, you can also do what ASF does and use DateTimeOffset yourself.

[JustArchi]

I've added a note in the changelog regarding that:

This release includes breaking change for Utilities.GetUnixTime(), if you're plugin creator and your plugin uses this function, you'll need to account for ulong instead of uint and recompile (#2594 @JustArchi).

Lack of it is probably the reason why you were confused. It's good you pointed it out - thanks for that.