Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects (code 307 and 308) are flagged as broken #638

Open
jthrilly opened this issue Nov 20, 2024 · 0 comments
Open

Redirects (code 307 and 308) are flagged as broken #638

jthrilly opened this issue Nov 20, 2024 · 0 comments

Comments

@jthrilly
Copy link

jthrilly commented Nov 20, 2024

Hello!

First of all, thank you for creating such a useful tool. It has saved us countless hours, and has increased the quality of our documentation website for our open source software. 🙏

We have two NextJs sites which use redirects in the root page. The first does this to redirect to a default locale (/en), and the second does this to redirect to a /dashboard route.

No matter if I use a temporary redirect (307) or permanent redirect (308) these requests are always flagged as broken by linkinator. My understanding of the HTTP spec is that 3xx codes are not to be treated as errors, but that the request may require further action on the part of the browser. I therefore believe linkinator should determine if the 3xx code is flagged as broken based on if the URL that is redirected to ultimately results in a 2xx code.

Alternatively, it would be great to have a simple option to not treat redirects as broken via a CLI flag.

I am happy to work on this if you let me know where to start.

Example domain for testing: https://fresco-sandbox.networkcanvas.com

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant