Create aws credential in controller test, remove old test artifacts a…

…ctions

Signed-off-by: Kyle Squizzato <[email protected]>

.github/workflows/test.yml

@@ -72,10 +72,6 @@ jobs:
       - name: Run E2E tests
         run: |
           make test-e2e
-      - name: Get test logs
-        run: |
-          kubectl logs -n hmc-system -l app=e2e-test > test/e2e/e2e-test.log
-          ./bin/clusterctl describe cluster --show-conditions=all > test/e2e/clusterctl.log
       - name: Archive test results
         uses: actions/upload-artifact@v4
         with:

test/e2e/e2e_test.go

@@ -60,6 +60,8 @@ var _ = Describe("controller", Ordered, func() {
 			kc, err := kubeclient.NewFromLocal(namespace)
 			ExpectWithOffset(1, err).NotTo(HaveOccurred())
 
+			ExpectWithOffset(1, kc.CreateAWSCredentialsKubeSecret(context.Background())).To(Succeed())
+
 			By("validating that the hmc-controller and capi provider controllers are running")
 			verifyControllersUp := func() error {
 				if err := verifyControllerUp(kc, hmcControllerLabel, "hmc-controller-manager"); err != nil {
@@ -185,6 +187,8 @@ func verifyControllerUp(kc *kubeclient.KubeClient, labelSelector string, name st
 		return fmt.Errorf("controller pod in %s status", controllerPod.Status.Phase)
 	}
 
+	_, _ = fmt.Fprintf(GinkgoWriter, "%s controller pod validation succeeded\n", name)
+
 	return nil
 }
 

test/kubeclient/kubeclient.go

@@ -124,8 +124,8 @@ func new(configBytes []byte, namespace string) (*KubeClient, error) {
 }
 
 // CreateAWSCredentialsKubeSecret uses clusterawsadm to encode existing AWS
-// credentials and create a secret named 'aws-credentials' in the given
-// namespace if one does not already exist.
+// credentials and create a secret in the given namespace if one does not
+// already exist.
 func (kc *KubeClient) CreateAWSCredentialsKubeSecret(ctx context.Context) error {
 	_, err := kc.Client.CoreV1().Secrets(kc.Namespace).Get(ctx, awsCredentialsSecretName, metav1.GetOptions{})
 	if !apierrors.IsNotFound(err) {