HMC chart installation fails with "Unable to continue with install: CustomResourceDefinition "certificaterequests.cert-manager.io" in namespace "" exists and cannot be imported"

[squizzi]

#193 introduced an issue when installing the HMC chart:

Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: CustomResourceDefinition "certificaterequests.cert-manager.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "hmc": current value is "cert-manager"; annotation validation error: key "meta.helm.sh/release-namespace" must equal "default": current value is "cert-manager"

Currently we have the following settings for the cert-manager subchart in our chart:

cert-manager:
  enabled: true
  crds:
    enabled: true <---

Setting that to false allows the chart to install without issues.

Maybe instead of relying on the chart to manage the cert-manager CRD we should use a finalizer in HMC to perform the deletion?

[Kshatrix]

What changed in #193 is that cert-manager CRDs are now removed when HMC is uninstalled. If you manage your own cert-manager, you can disable it with cert-manager.enabled=false. If, for some reason, you already have CRDs created, you can disable CRD creation as well. By default, we assume there's no cert-manager present in the cluster and install both cert-manager and its CRDs.