Fix AWS hosted cluster template networking issue (fixes #788) #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
requested review from
Kshatrix,
eromanova and
a13x5
as code owners
…ent cluster name which is required for networking to work with AWS. Also switched to using the forked version of the AWS cloud provider helm chart so we can support this.
kylewuolle
force-pushed
the
fix-aws-hosted
branch
from
4397a8d to
45f6d60
Compare
a13x5
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Minor notes.
@kylewuolle did you research a possibility to pass managementClusterName automatically?
For example we could do in the same way we're passing credential values
| @@ -55,6 +55,10 @@ spec: | |||
| - --cluster-cidr={{ first .Values.clusterNetwork.pods.cidrBlocks }} | |||
| - --allocate-node-cidrs=true | |||
| - --cluster-name={{ include "cluster.name" . }} | |||
| cloudConfig: | |||
| enabled: {{ ne .Values.managementClusterName "" }} | |||
There was a problem hiding this comment.
Better to have just true here, since without it it won't work anyway
| cloudConfig: | ||
| enabled: {{ ne .Values.managementClusterName "" }} | ||
| global: | ||
| KubernetesClusterID: {{ .Values.managementClusterName }} |
There was a problem hiding this comment.
And then we can just have required if you want to have some guards on that value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set the management cluster name in the AWS hosted template. This is needed because of issue #788. Requires PR Mirantis/helm-charts#2 to be merged and the resulting helm chart to be published. An upstream PR for the change to the chart has been created : kubernetes/cloud-provider-aws#1085.