-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup implementation: controller, plugins, collection, webhooks #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerospiel
force-pushed
the
backup_impl_2
branch
2 times, most recently
from
December 30, 2024 12:16
80beb93
to
9694287
Compare
zerospiel
changed the title
Backup impl 2
Backup implementation: controller, plugins, collection, webhooks
Dec 30, 2024
zerospiel
force-pushed
the
backup_impl_2
branch
9 times, most recently
from
January 6, 2025 16:01
56f0846
to
dd516c2
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
5 times, most recently
from
January 8, 2025 17:52
d8b1204
to
e581f96
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
4 times, most recently
from
January 9, 2025 18:21
d95cd1c
to
fb31e55
Compare
Kshatrix
requested changes
Jan 10, 2025
zerospiel
force-pushed
the
backup_impl_2
branch
4 times, most recently
from
January 13, 2025 11:26
86eb134
to
00f57d2
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
3 times, most recently
from
January 16, 2025 12:30
e407f4e
to
050229f
Compare
zerospiel
commented
Jan 16, 2025
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 16, 2025 13:41
050229f
to
eae97ef
Compare
eromanova
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general but the backup logic requires final approval from Andrey.
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 16, 2025 17:31
eae97ef
to
36af080
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 16, 2025 17:35
36af080
to
287f6bb
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 17, 2025 09:07
287f6bb
to
d621663
Compare
Should chart versions be updated because of the change to the provider label values? |
zerospiel
force-pushed
the
backup_impl_2
branch
3 times, most recently
from
January 17, 2025 13:18
ec72808
to
320b164
Compare
Kshatrix
requested changes
Jan 20, 2025
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 20, 2025 14:19
1ca1a7c
to
db4d263
Compare
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 20, 2025 14:24
db4d263
to
02060c1
Compare
* install velero via flux rather than code * adjust roles for the velero chart * remove unnecessary controller values * rename Backup to ManagementBackup * remove Oneshot parameter from the Spec * add StorageLocation to both Management and ManagementBackup * remove unused types * manage schedules in the ctrl instead of velero * new source runner for schedules * collect the required velero backup spec for the whole backup * label Credential references (clusterIdentities) in order to include them in backup * backup validation webhook * amend backup controller logic with better objects handling * fix bug in providertemplates ctrl when ownerreferences are being updated but requeue is not set * add custom plugins set via mgmt spec * rename k0smotron related provider labels to the correct ones from the k0sproject
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 20, 2025 14:29
02060c1
to
c318cd7
Compare
* remove velero watcher from mgmtbackup ctrl * remove velero enabled flag * remove mgmt.backup spec * remove webhooks for mgmt/mgmtbackups * indexer now caches schedules and incomplete backups * mgmtbackup spec extended with schedule * mgmtbackup ctrl now does not rely on mgmt object * simplify mgmtbackup ctrl logic * set error to mgmtbackup on meta API errors * fix error with getting next attempt time
zerospiel
force-pushed
the
backup_impl_2
branch
from
January 20, 2025 15:10
c318cd7
to
e665dd1
Compare
Kshatrix
approved these changes
Jan 20, 2025
eromanova
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backup implementation main part contains the following changes:
To properly test the feature:
k0rdent
instance (better with aclusterdeployment
ready) with this PRbackupstoragelocation
forvelero
, e.g.management
, set.spec.backup
to the something like{enabled: true; schedule: "@every 5m"}
k0rdent
instance (imitate a disaster)The restoration process:
k0rdent
installation (withoutmgmt
/releases
/etc)backup location
(see above) to be able to fetchbackups
from a cloud storagevelero restore
(e.g.velero restore create <name> --existing-resource-policy update --from-backup <backup-name>
)Completed
state (e.g. withvelero restore get
)#814