Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible change in kairos 1.1.3 #1

Open
ConradWood opened this issue Dec 19, 2017 · 1 comment
Open

incompatible change in kairos 1.1.3 #1

ConradWood opened this issue Dec 19, 2017 · 1 comment

Comments

@ConradWood
Copy link

the kairosdb aggregator interface has changed sometime pre 1.1.3. Kise compiles with the interface
public interface Aggregator {
public DataPointGroup aggregate(DataPointGroup dpg);
public boolean canAggregate(String string);
}
whereas in 1.1.3 it actually is:

public interface Aggregator
{ DataPointGroup aggregate(DataPointGroup dataPointGroup);
boolean canAggregate(String groupType);
String getAggregatedGroupType(String groupType);
}

This leads to a AbstractMethodError when attempting to use it in kairos1.1.3.

The AvgAggregator in Kairos 1.1.3 implements this function as:

public String getAggregatedGroupType(String groupType)
{
return m_dataPointFactory.getGroupType();
}

which seems to make some sense (but I don't know exactly why I would want to change the aggregated group type).
My suggestion is to add this implementation (it seems reasonable), as otherwise it does not work at all.
Cheers,

Conrad

@lcoulet
Copy link
Member

lcoulet commented Apr 16, 2018

Hi, thanks for this report. 1.1.3 was a temporary release but now that 1.2 has been release I will update this plugin accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants