-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub version bump action always bumps at least minor #79
Comments
Kinda okayish inspiration for a custom implementation: A Python script/tool could be useful as well, e.g. bump2version |
See #87 |
The reason for the major release is a stupid one. The PR description contained
After sanitizing that you get
which contains #major which caused a major release. Merging #87 fixes the version and I think we can close this issue again after. That's a stupid coincidence that I doubt will happen again. |
And I wondered, if you might want to preserve whitespaces as well 😅 |
I guess we could adjust the sanitizing to keep whitespaces too just to make it less likely of this happening again 👍 |
Our GitHub version bump action has this version bump combination logic based on commit messages (see also KIT-MRT/util_caching#38 (comment)).
It seems that in our setup with a PR merge commit, this leads to version bumping based on
In #75, this lead to a minor bump, even though the only PR commit 3586225 contains the
#patch
tag.That's probably, because the PR merge commit does not contain a bump tag – thus, defaulting to
#minor
It's a pity we have so much trouble with the version bump action 🙈
@ll-nick Any idea how we can fix this? Should we default to
#patch
again?The text was updated successfully, but these errors were encountered: