Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub version bump action always bumps at least minor #79

Closed
orzechow opened this issue Nov 19, 2024 · 7 comments · Fixed by #85
Closed

GitHub version bump action always bumps at least minor #79

orzechow opened this issue Nov 19, 2024 · 7 comments · Fixed by #85
Assignees

Comments

@orzechow
Copy link
Member

Our GitHub version bump action has this version bump combination logic based on commit messages (see also KIT-MRT/util_caching#38 (comment)).
It seems that in our setup with a PR merge commit, this leads to version bumping based on

  • the PR commits
  • plus the PR merge commit

In #75, this lead to a minor bump, even though the only PR commit 3586225 contains the #patch tag.
That's probably, because the PR merge commit does not contain a bump tag – thus, defaulting to #minor

It's a pity we have so much trouble with the version bump action 🙈

@ll-nick Any idea how we can fix this? Should we default to #patch again?

@orzechow
Copy link
Member Author

orzechow commented Nov 19, 2024

Kinda okayish inspiration for a custom implementation:
https://chatgpt.com/share/673c56c9-d468-8010-a15c-0bc2db517f69

A Python script/tool could be useful as well, e.g. bump2version

@orzechow
Copy link
Member Author

orzechow commented Nov 21, 2024

Well that worked "well" 😅

image

I deleted that release

@orzechow orzechow reopened this Nov 21, 2024
@ll-nick
Copy link
Collaborator

ll-nick commented Nov 21, 2024

See #87

@ll-nick
Copy link
Collaborator

ll-nick commented Nov 21, 2024

The reason for the major release is a stupid one. The PR description contained

of one of the following flags (proceeded by a #):

  • major

After sanitizing that you get

ofoneofthefollowingflagsproceededbya#major

which contains #major which caused a major release.

Merging #87 fixes the version and I think we can close this issue again after. That's a stupid coincidence that I doubt will happen again.

@orzechow
Copy link
Member Author

orzechow commented Nov 21, 2024

And I wondered, if you might want to preserve whitespaces as well 😅
Would that be unsafe?

@ll-nick
Copy link
Collaborator

ll-nick commented Nov 21, 2024

I guess we could adjust the sanitizing to keep whitespaces too just to make it less likely of this happening again 👍

@orzechow
Copy link
Member Author

Closed by #85 #87 and #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants