Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #82

Closed
wants to merge 5 commits into from
Closed

Tutorial #82

wants to merge 5 commits into from

Conversation

orzechow
Copy link
Member

We never plan to merge this (it intentionally strips down the demo code for the tutorial, see #51 )

Let's have this PR for code review though.

@orzechow
Copy link
Member Author

@ll-nick This is ready for review as well 🎉

@ll-nick
Copy link
Collaborator

ll-nick commented Nov 26, 2024

I did the tutorial again yesterday and I did not run into issues that were caused by the state of this branch (except one tiny thing that should be fixed by a rebase to main). See #51 (comment)

@orzechow orzechow force-pushed the pacman-tutorial-website branch from 3e25743 to cbaf5aa Compare November 26, 2024 19:55
Base automatically changed from pacman-tutorial-website to main November 26, 2024 20:02
@orzechow
Copy link
Member Author

Alright, thanks for the feedback!
Closing without merging (this branch is not meant to be merged).

@orzechow orzechow closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants