Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy as debian package #8

Closed
2 tasks done
orzechow opened this issue Nov 6, 2024 · 3 comments · Fixed by #21
Closed
2 tasks done

Deploy as debian package #8

orzechow opened this issue Nov 6, 2024 · 3 comments · Fixed by #21
Assignees

Comments

@orzechow
Copy link
Member

orzechow commented Nov 6, 2024

Inspired by KIT-MRT/arbitration_graphs#65, let's

  • setup CPack for util_caching and
  • deploy util_caching as debian package (via GitHub Action asset)
@orzechow
Copy link
Member Author

orzechow commented Nov 8, 2024

@ll-nick Should we install util_caching into /opt instead of /usr etc?
There are various opinions on this (e.g. this unix stackexchange answer).

The main point against /usr IMHO is, that is suggests the package is deployed via a package manager like apt – which is not the case here.

Btw:
In an attempt to fix the install directory of the arbitration_graphs GUI (consistent between tar.gz, deb package and local cmake --install), I changed the install directory to /opt there.
Thus, I'd prefer to have this consistent here as well.
But, we could also use /usr for arbitration_graphs (i.e. force it for tar.gz and local cmake --install)

@orzechow
Copy link
Member Author

orzechow commented Nov 8, 2024

Yikes… I just figured that the /opt install of arbitration graphs is off…

KIT-MRT/arbitration_graphs#70 (comment)

@ll-nick
Copy link
Collaborator

ll-nick commented Nov 11, 2024

I don't have a strong opinion on that. /opt does not seem right but that's a pure gut feeling.

Right now, the deb package is not being installed via a package manager but what if one day it is (e.g. via a ppa). Would you then change the install structure?

It seems like you opted for /usr now which is totally fine for me 👍

@orzechow orzechow linked a pull request Nov 11, 2024 that will close this issue
ll-nick added a commit that referenced this issue Nov 11, 2024
Add GitHub actions to run unit tests and deploy releases. Closes #8 #major
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants