Add support for catkin_make_isolated, catkin build #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Add support for `catkin_make_isolated`, `catkin build` ## Description Only `catkin_make` does export the the compiler info as required for the pre-checks. While `catkin_make_isolated` and especially `catkin build` do use the same compilers as `catkin_make` it is not visible to cmake. The reason is, that both `catkin_make_isolated` and `catkin build` build the code in an isolated environment to suppress cross-talk while building. Therefore, the top-level compiler variables are not available. Thus, only check for the required controllers, if the code is not build using ROS. ## Proof On a vanilla Ubuntu 16.04 with ROS Kinetic, the following variables are exported: `catkin_make`: - `CMAKE_CXX_COMPILER`: /usr/bin/c++ - `NEWER_GNU_CXX_COMPILER`: - `CMAKE_CXX_COMPILER_ID`: GNU - `CMAKE_CXX_COMPILER_VERSION`: 5.4.0 `catkin_make_isolated`: - `CMAKE_CXX_COMPILER`: /usr/bin/c++ - `NEWER_GNU_CXX_COMPILER`: NEWER_GNU_CXX_COMPILER-NOTFOUND - `CMAKE_CXX_COMPILER_ID`: - `CMAKE_CXX_COMPILER_VERSION`: `catkin build`: - `CMAKE_CXX_COMPILER`: NEWER_GNU_CXX_COMPILER-NOTFOUND - `NEWER_GNU_CXX_COMPILER`: NEWER_GNU_CXX_COMPILER-NOTFOUND - `CMAKE_CXX_COMPILER_ID`: - `CMAKE_CXX_COMPILER_VERSION`:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
catkin_make_isolated,catkin buildDescription
Only
catkin_makedoes export the the compiler info as required for the pre-checks.While
catkin_make_isolatedand especiallycatkin builddo use the same compilers ascatkin_makeit is not visible to cmake.The reason is, that both
catkin_make_isolatedandcatkin buildbuild the code in an isolated environment to suppress cross-talk while building.Therefore, the top-level compiler variables are not available.
Thus, only check for the required controllers, if the code is not build using ROS.
Proof
On a vanilla Ubuntu 16.04 with ROS Kinetic, the following variables are exported:
catkin_make:CMAKE_CXX_COMPILER: /usr/bin/c++NEWER_GNU_CXX_COMPILER:CMAKE_CXX_COMPILER_ID: GNUCMAKE_CXX_COMPILER_VERSION: 5.4.0catkin_make_isolated:CMAKE_CXX_COMPILER: /usr/bin/c++NEWER_GNU_CXX_COMPILER: NEWER_GNU_CXX_COMPILER-NOTFOUNDCMAKE_CXX_COMPILER_ID:CMAKE_CXX_COMPILER_VERSION:catkin build:CMAKE_CXX_COMPILER: NEWER_GNU_CXX_COMPILER-NOTFOUNDNEWER_GNU_CXX_COMPILER: NEWER_GNU_CXX_COMPILER-NOTFOUNDCMAKE_CXX_COMPILER_ID:CMAKE_CXX_COMPILER_VERSION: