Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CplxTrans (and VCplxTrans?) on negative floats/ints #1747

Closed
sebastian-goeldi opened this issue Jun 18, 2024 · 0 comments · Fixed by #1753
Closed

CplxTrans (and VCplxTrans?) on negative floats/ints #1747

sebastian-goeldi opened this issue Jun 18, 2024 · 0 comments · Fixed by #1753
Assignees
Milestone

Comments

@sebastian-goeldi
Copy link
Contributor

sebastian-goeldi commented Jun 18, 2024

Hello Matthias,

I don't know how much work it would be, but would it be possible to add or change the CplxTrans, and I think the VCplxTrans would also be necessary, to allow the usage on signed int instead of only unsigned int?

Reasoning being I added this gdsfactory/kfactory#404 and didn't read the API properly before :P (the function there just takes any of the __mul__ overloaded types and returns CplxTrans(layout.dbu) * input (or inverted in the to_um case))

I can work around it, but it would be nicer if the transformations directly support it. Of course only if the change is reasonable and wouldn't jeopardize other API.

@sebastian-goeldi sebastian-goeldi changed the title CplxTrans (and VCplxTrans?) on negative floats CplxTrans (and VCplxTrans?) on negative floats/ints Jun 18, 2024
@klayoutmatthias klayoutmatthias self-assigned this Jun 22, 2024
@klayoutmatthias klayoutmatthias added this to the 0.29.3 milestone Jun 22, 2024
klayoutmatthias pushed a commit that referenced this issue Jun 22, 2024
klayoutmatthias added a commit that referenced this issue Jun 29, 2024
Fixing issue #1747 (signed coordinate transformations with Trans/DTra…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants