Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.29.3 - crash when deleting shapes with multiple shapes selected #1780

Closed
klayoutmatthias opened this issue Jul 8, 2024 · 3 comments · Fixed by #1783
Closed

0.29.3 - crash when deleting shapes with multiple shapes selected #1780

klayoutmatthias opened this issue Jul 8, 2024 · 3 comments · Fixed by #1783
Assignees
@klayoutmatthias
Labels
bug
Milestone
0.29.4

Comments

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Jul 8, 2024 •
edited
Loading

To reproduce:

  • Open a layout in editor mode, can be a flat one
  • Select multiple shapes
  • Use "delete"

Result: the program crashes.

This problem did not occur in version 0.29.2.
@klayoutmatthias klayoutmatthias added this to the 0.29.4 milestone Jul 8, 2024
klayoutmatthias pushed a commit that referenced this issue Jul 8, 2024
Bugfix issue #1780
930a5d7
@klayoutmatthias klayoutmatthias linked a pull request Jul 8, 2024 that will close this issue
Bugfix issue #1780 #1783
Merged
@klayoutmatthias klayoutmatthias self-assigned this Jul 8, 2024
klayoutmatthias added a commit that referenced this issue Jul 8, 2024
@klayoutmatthias
Merge pull request #1783 from KLayout/bugfix/issue-1780
b4b2b57 
Bugfix issue #1780
klayoutmatthias pushed a commit that referenced this issue Jul 8, 2024
WIP: post-fix for #1780 - minimizing access to 'selection' which is m…
12d0968 
…utable.
@Kazzz-S
Copy link
Contributor

Kazzz-S commented Jul 8, 2024

Hello @klayoutmatthias,

Please let me know if you plan to release 0.29.4 soon to address this bug.
If so, I'll skip building 0.29.3 for Mac and wait for release 0.29.4.
After some testing, I just started building, so the impact is negligible.

Regards,
Kazzz-S

@klayoutmatthias
Copy link
Collaborator Author

Thanks for asking! I have actually released 0.29.4 now.

I hope you did not waste effort. I think it is okay to skip 0.29.3.

Sorry for the trouble,

Matthias

@Kazzz-S
Copy link
Contributor

Kazzz-S commented Jul 9, 2024 •
edited
Loading

Thanks for the hotfix.
No worry. I'll do so.
I started building 0.29.4 at the office.

Kazzz-S

[Edit] On Mac, I could reproduce the crash (0.29.3) and confirmed the fix (0.29.4),

@Kazzz-S Kazzz-S mentioned this issue Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
bug
Projects
None yet
Milestone
0.29.4
Development

Successfully merging a pull request may close this issue.

Bugfix issue #1780 KLayout/klayout
2 participants
@Kazzz-S @klayoutmatthias