Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes on certain layer not selectable #1870

Closed
martinjankoehler opened this issue Sep 24, 2024 · 5 comments · Fixed by #1876
Closed

Shapes on certain layer not selectable #1870

martinjankoehler opened this issue Sep 24, 2024 · 5 comments · Fixed by #1876
Assignees
Labels
Milestone

Comments

@martinjankoehler
Copy link
Contributor

Version: KLayout 0.29.7, commit 2d4f5d8

I can't select shapes on mcon.pin 78748, also the icon shows an X:
Bildschirmfoto 2024-09-24 um 16 14 17

Not sure if this is a bug or a PEBKAC, but if the latter, where can this behaviour be configured/toggled?

Demo Video:
https://github.com/user-attachments/assets/9f7166af-9457-443d-ab50-686a766f9795

GDS:
klayout_unselectable_mcon-pin.gds.gz

@sebastian-goeldi
Copy link
Contributor

sebastian-goeldi commented Sep 24, 2024

Hello,

I believe that's because the layer is not set as valid (there is a flag to make a layer valid/invalid). I am on mobile, so I cannot test. Could you test whether it works if you right click the layer and click "Make layer valid" (or similar name, can't remember the exact wording). This is a setting gotten from the .lyp file (or technology if that's what you use)

@martinjankoehler
Copy link
Contributor Author

@sebastian-goeldi Thanks, I can confirm it works exactly like you told!

@klayoutmatthias OK, then IMO KLayout should warn when somebody attempts to draw in an invalid layer,
perhaps similar like it already warns when somebody tries to draw without any layer selected:
Bildschirmfoto 2024-09-24 um 19 55 21

@sebastian-goeldi
Copy link
Contributor

For selection this is the intended behavior.
https://klayout.de/doc/manual/layer_validity.html

I can't really speak for drawing, as I never use the GUI for drawing but rather the python/pypi standalone for drawing and the GUI for viewing. But if the GUI doesn't let you draw on a invalid layer, I think yes it would make sense for it to throw an error message like it does when no layer is selected.

@martinjankoehler
Copy link
Contributor Author

martinjankoehler commented Sep 24, 2024

But if the GUI doesn't let you draw on a invalid layer, I think yes it would make sense for it to throw an error message like it does when no layer is selected.

Yeah currently it actually allows drawing but not selecting of invalid layers, which to me seems inconsistent (from a UX perspective).
That's what happened in my use case, I wanted 'met1.pin' (valid) but somehow selected 'mcon.pin' (invalid),
and then accidentally drew a box which I was not able to remove again (at least not by selection and delete key).

@klayoutmatthias
Copy link
Collaborator

I see ...

Yes I agree. It never occured to me to draw on an invalid layer, but there should at least be some warning. Like when you try to draw on an invisible layer - which is equally confusing :)

Matthias

@klayoutmatthias klayoutmatthias self-assigned this Sep 28, 2024
@klayoutmatthias klayoutmatthias added this to the 0.29.8 milestone Sep 28, 2024
klayoutmatthias added a commit that referenced this issue Oct 6, 2024
Bugfix for issue #1870: do not allow editing on invalid layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants