Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read lef/def feature request: issue WARNING if VIA SPACING is an odd number #1892

Closed
stefanottili opened this issue Oct 12, 2024 · 3 comments · Fixed by #1889
Closed

read lef/def feature request: issue WARNING if VIA SPACING is an odd number #1892

stefanottili opened this issue Oct 12, 2024 · 3 comments · Fixed by #1889
Milestone

Comments

@stefanottili
Copy link

This is a feature request triggered by #1877

When reading lef, an odd number for VIARULE..LAYER..SPACING will lead to rounding issues.
That's because via geometry has to be centered and thus there will be a divide by two used in the calculation of the anchor point of the top/bottom rectangle.

Issue a WARNING if the lef VIARULE..LAYER..SPACING is an odd number.
Issue a WARNING if the def VIA + CUTSPACING is an odd number.

@stefanottili
Copy link
Author

stefanottili commented Oct 13, 2024

come to think about it, just issue a WARNING if there is division by two of an odd number when reading the def VIA.

@klayoutmatthias
Copy link
Collaborator

Yes, I agree, there should be a warning. Basically, it's the via array bounding box which should not have a odd width or height.

I'd prefer to fix this along with #1877 because there is already a test case.

Thanks,

Matthias

@klayoutmatthias
Copy link
Collaborator

I have included the warning into the #1877 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants