Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceSyncSceneSwitch patch cause the parts PAW UI to be as if they were in flight after reverting to VAB #260

Closed
JonnyOThan opened this issue Oct 11, 2024 · 6 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@JonnyOThan
Copy link
Contributor

I got a report from someone who was using the standalone dll from #250

and also, whenever you revert to VAB with that scene switch patch, it treats parts as though you're still in flight
ie, can't change subtypes, other editor stuff
only flight stuff

@JonnyOThan JonnyOThan added the unconfirmed Can't reproduce, more information needed label Oct 11, 2024
@JonnyOThan JonnyOThan added this to the 1.36 milestone Oct 15, 2024
@siteonfly
Copy link

Confirm after updating to 1.36

@siimav
Copy link
Contributor

siimav commented Oct 20, 2024

Culprit has already been found: #273

@gotmachine
Copy link
Contributor

gotmachine commented Oct 20, 2024

Confirm after updating to 1.36

What exactely is happening in your case ? We identified a mod compatibility issue with Universal Storage, but what happens with that issue doesn't really match the "parts are treated as if they were still in flight after reverting to the VAB" description. Can you expand a bit (a screenshot would be nice) and upload your ksp.log ?

@gotmachine gotmachine changed the title Investigate: SyncSceneSwitch behavior on revert to VAB ForceSyncSceneSwitch patch cause the parts PAW UI to be as if they were in flight after reverting to VAB Oct 20, 2024
@gotmachine gotmachine added the bug Something isn't working label Oct 20, 2024
@siteonfly
Copy link

siteonfly commented Oct 21, 2024

After revert I cant change some params, for example SRB's max throtle, command pods kerbalism settings, service bays appearance and etc.
This is before launch
before_launch
This is after revert
after_revert
log file
KSP.zip

@siteonfly
Copy link

Forget to notice that I also have US2 installed

@JonnyOThan JonnyOThan added duplicate This issue or pull request already exists and removed unconfirmed Can't reproduce, more information needed labels Oct 21, 2024
@JonnyOThan
Copy link
Contributor Author

Confirmed that I can repro with kspcf 1.36.0 and US2, and does not repro without US2.

@JonnyOThan JonnyOThan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Development

No branches or pull requests

4 participants