You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From a quick review, I haven't see anything that would cause real issues, most of the time the method is used to set a field to zero when that field is meaningless in the current context, but it could theoretically lead to other pieces of code making wrong assumptions. The only case I would somewhat worry about is the VesselPrecalculate.CalculatePhysicsState() one, and we are fixing it already through the flight perf patches.
The CenterOfLift / CenterOfThrust cases might be responsible for some weirdness with the CoL/CoT markers in the editor, IDK.
One case that look like it could be introducing some weirdness is thePartBuyoancy.lastBuoyantForce field, but in the end it probably doesn't matter too much. Note that we are already prefixing PartBuyoancy.FixedUpdate(), so it might be worth it to just override the whole method if we choose to fix it.
The following stock method in
VectorExtensions
:doesn't work as it doesn't pass the vector by ref.
That method is used in a variety of stock code paths :
Not much we can do as we can't change the method signature, but well, keeping this here as a reminder...
The text was updated successfully, but these errors were encountered: