Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollisionEnhancerFastUpdate can spew NREs with certain other mods #282

Open
JonnyOThan opened this issue Nov 4, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Nov 4, 2024

I don't have many details but I opened the console to see that there were NREs spewing and it looks like it's the collision enhancer patch. I have Firefly and parallax continued installed which may be related.

[EXC 22:26:28.704] NullReferenceException: Object reference not set to an instance of an object
    KSPCommunityFixes.Performance.CollisionEnhancerFastUpdate.CollisionEnhancer_FixedUpdate_Prefix (CollisionEnhancer __instance) (at <e997dbbd4fda4eacb68a00719aa5e5dc>:0)
    (wrapper dynamic-method) CollisionEnhancer.CollisionEnhancer.FixedUpdate_Patch1(CollisionEnhancer)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
@JonnyOThan JonnyOThan added the bug Something isn't working label Nov 4, 2024
@gotmachine
Copy link
Contributor

A bit of context (and the full log) could help...
Happening continuously or on some event / specific situation ?

But likely this is because I removed the null check for the part, or because I'm accessing the vessel.

gotmachine added a commit that referenced this issue Nov 7, 2024
…, but added back a few null checks to handle things more gracefully.
@OrbitalManeuvers
Copy link

Here's a folder with a full log and settings.cfg. Launching fireworks triggers this nullref spam until firework explodes.

https://drive.google.com/drive/folders/1idtJw9CxYYnJIMz4ShxlM8wiTUYy87Aw?usp=sharing

gotmachine added a commit that referenced this issue Nov 19, 2024
The CollisionEnhancer component can actually exist on non-part objects such as physical objects and fireworks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants