Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple slub_debug and no_hash_pointers #368

Open
kees opened this issue Feb 19, 2025 · 1 comment
Open

Decouple slub_debug and no_hash_pointers #368

kees opened this issue Feb 19, 2025 · 1 comment
Labels
[Defense] information exposure Provide a defense for an information exposure enhancement New feature or request

Comments

@kees
Copy link

kees commented Feb 19, 2025

When booting with "slub_debug=FZ", hashed pointers are disabled.

The source of the problem is commit
7927029 ("slub: force on no_hash_pointers when slub_debug is enabled")

I objected at the time:
https://lore.kernel.org/all/202109200726.2EFEDC5@keescook/
But it was never reverted.

If someone could send a patch that would decouple these again, I'd appreciate it. I think it would be best to refactor the boot param "no_hash_pointers" into "hash_pointers={auto,always,never}", with the old setting meaning "hash_pointers=never", but the default being "=auto" that falls back to this case where slub debug turns it off. But that would allow for "slub_debug=FZ hash_pointers=always" and we could have the best of both worlds.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1098362

@kees kees added [Defense] information exposure Provide a defense for an information exposure enhancement New feature or request labels Feb 19, 2025
@sperezglz
Copy link

sperezglz commented Apr 1, 2025

Hi, I saw this issue and started to look into it. I have a patch cf76d5a, but before sending it for wider review I wanted to check-in and see if this is what you had in mind and looks ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Defense] information exposure Provide a defense for an information exposure enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants