-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using meson format to help with consistency #40
Comments
TLDR: For now consistency in formatting is not too important, feel free to write code more or less as it comes with your current configuration :). As a follow up of the conversation we had earlier, I think This repo, at this point in time, is handling: c, cpp, swift, markdwon, xml, ts, json, yaml, meson & possibly more. Structuring a process to ensure consistency on every major editor for all these languages, and expecting a contributor to have all the equivalent extensions installed is not really an option. As I suggested, prettification should be part of the CI, and condition for a merge to be possible. If failing, a bot should apply any normalization automatically, and submit it as PR. This also means that developers should not really care to match the prior "style" being used all that much. At some point, a robot will (hopefully) be handling that on our behalf. |
That should make things easier in the long run. |
For my own future reference: |
This one is simpler; it just fails the PR if the code-formatting is incorrect: |
For reference: https://github.com/super-linter/super-linter |
meson format
is a thing now. https://mesonbuild.com/Commands.html#formatI'm going to open a PR to add an .editorconfig file which can be used for that. I think it will help maintain consistency. I can spend less time trying to make sure my formatting is correct when working on meson here.
Sound good?
The text was updated successfully, but these errors were encountered: