-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dockerfile and workflow #8
Conversation
I think I followed the instructions here https://apt.llvm.org/
Depending on the base image used, many packages needed for development are missing. If I recall correcty debian is much more basic compared to the full ubuntu image here on github actions. It might not even have git out of the box Otherwise, appending
to |
I'm using trixie-slim for the base image. I found that clang-19 is actually available without adding anything to the source list. :) This doesn't work because it requires |
e2f0775
to
1a0d77e
Compare
The main problem with this as it is: builder may not have privileges to write the build directory or create the node_modules directory. I deal with this issue in this other project I work on by using an entrypoint.sh file. It works out not too bad but maybe me, or you and I, can think of a better solution. But no need to prioritize this PR. |
apt using the trixie-slim image only told me those package weren't available.
Not sure if I understood correctly, but the flatpak builder expects |
I can relate to that! :)
I'm kind of shot for the night but I'll try to elaborate. The solution might be very simple after I get some rest. Or you'll have it all figured out, but When the image is run with the -v option (as in the examples I've documented), it's mounting the source directory. All commands are executed as 'builder', the user created in the Dockerfile. 'builder' may not have permissions to create directories because he/she/they/zirs has a different UID than the source directory. In the entrypoint.sh file I linked to above, I solve this by having root (in the container) change the UID of builder to the UID of whoever started the container. |
No problem :D. I will need some time to read that and the example your posted properly, thank you for the additional context. |
1a0d77e
to
122db0d
Compare
86ea7c7
to
4f4ba59
Compare
While building, not finding entrypoint.sh. I have no idea why. It works locally. I'll get back to it later. |
4f4ba59
to
6f5e5e0
Compare
I had duplicate build steps that conflicted. Fixed. Remaining issues:
Probably some other minor issues :) |
b83b15e
to
154df81
Compare
154df81
to
59b63c2
Compare
@KaruroChori I think what I have here so far is gonna be pretty close to the end result. I've converted this from draft to review. I'll do a bit more testing and doc proof-reading much later on today. |
- '**docker.yml' | ||
# workflow_dispatch: | ||
# schedule: | ||
# - cron: '30 11 20 */3 *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often would you like this automatically built?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any suggestion for that?
I think once each fortnight is probably enough, possibly even too much.
I mean, if there are good reasons to have a new image asap we can just trigger it manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I thought a fortnight as well, although since I'm an American I actually thought two weeks. ;) But... monthly should be alright, because as you said, we can trigger it manually, or change the cron setting
Great! I will also be reviewing & testing it later today :D. |
How do you install clang-19 on Trixie?