Opt-in email notifications when {repo sync, cv promote, cv publish, proxy sync} fails

[adamruzicka]

What are the changes introduced in this pull request?

Opt-in email notifications when {repo sync, cv promote, cv publish, proxy sync} fails

Considerations taken when implementing this change?

What are the testing steps for this pull request?

1. Subscribe to each of the things mentioned above
2. Make them fail. In general raise "HALT" somewhere in the action works pretty well, but it cannot happen before action_subject is called

TODO:

• redmine

[adamruzicka]

Do these four actions always fail hard or do they go into paused?

[sjha4]

IIRC syncs fail and go to stopped/error state.. Promote/Publish pause upon errors.

[adamruzicka]

Changed to send the emails out when things either fail or get paused just to be extra sure

[sjha4]

I am getting this error. Not sure if any additional config is needed. I turned on the notifications in User details for the 4 new actions.

15:06:34 rails.1 | 2023-09-21T15:06:34 [E|dyn|b194a130] Failed to run hook 'notify_on_failure' for action 'Actions::Katello::CapsuleContent::Sync' 15:06:34 rails.1 | 2023-09-21T15:06:34 [E|dyn|b194a130] undefined method users' for nil:NilClass (NoMethodError)
15:06:34 rails.1 | b194a130 | /home/vagrant/katello/app/lib/actions/katello/capsule_content/sync.rb:56:in notify_on_failure'

[adamruzicka]

Is your db seeded? If you run MailNotification[:capsule_sync_failure] in rails console, what does it give you? Scratch that. Originally I used downstream terminology and then just renamed it to upstream one, but failed to propagate the changes into all the right places

[sjha4]

Seems to be working now! Will test some more..I don't seem to have sendmail correctly set up on my box so verifing the emails in the console. Will do some more testing.

[sjha4]

Able to see emails on repo sync, capsule sync, cv publish and promote failures.
Ack 👍🏼