Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer.rs has a different render result with render.rs #14

Open
oUp2Uo opened this issue Aug 23, 2024 · 4 comments
Open

viewer.rs has a different render result with render.rs #14

oUp2Uo opened this issue Aug 23, 2024 · 4 comments

Comments

@oUp2Uo
Copy link

oUp2Uo commented Aug 23, 2024

Thanks for the great work, it is very useful to view the compressed npz model.

Today, occasionally, I found viewer.rs has a different render result with render.rs for a same model on the same camera position. And this is the first position.

viewer.rs
viewer

render.rs
00000

Not all position different, just 1st in this image sequence(~60).
I have tried to change the rendering order of test and train, and this time the 1st in train got error.
It seems that render.rs's result is not correct at the first position.

Do you have any idea about this?
Thank you.

@KeKsBoTer
Copy link
Owner

Nice reconstruction!
This seems to be an issue with the sorting. I have to check if something is incorrect with the setup there :/

@oUp2Uo
Copy link
Author

oUp2Uo commented Aug 23, 2024

Thanks for the reply.
I have done some more test, and edited the article.
It seems that only the 1st image has error.
Maybe some bug in initialization?

@oUp2Uo
Copy link
Author

oUp2Uo commented Sep 25, 2024

Hi, after some more tests, I found other differences between video.rs and render.rs:
render.rs could output images in any resolution, but video.rs could not.
For example, 4k x 2k may ok, but 4001 x 2001 could not.

I found function download_texture is different in these two program.
And wgpu::TextureFormat is also different.

@oUp2Uo
Copy link
Author

oUp2Uo commented Nov 14, 2024

Hi, with these days' tests, I found this bug not only exist in render.rs, but also video.rs.
Although they have different download_texture and download_buffer functions, there would be error render result image in these two program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants