Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible small bug in makemask in reduce/calib.py #33

Open
cdfassnacht opened this issue Jul 23, 2024 · 0 comments
Open

Possible small bug in makemask in reduce/calib.py #33

cdfassnacht opened this issue Jul 23, 2024 · 0 comments

Comments

@cdfassnacht
Copy link

In looking through the code for the makemask function in calib.py, I noticed what may be a small cut-and-paste bug. In line 297 (as seen by looking at the file on github.com using a web browser) the flat_stats variable is defined by a call to stats.sigma_clipped_stats. I think that this should give statistics for the flats, but the input list is img_dk rather than img_fl, as I would expect and as is used in the else portion of this if/else structure. Perhaps this bug never causes problems if people are using up-to-date versions of astropy, but I thought I should bring it to your attention nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant