From 5a705c4c907a7cd53e213744c0aded864a6712a5 Mon Sep 17 00:00:00 2001 From: Dave Hughes Date: Tue, 29 Sep 2020 09:50:26 -0700 Subject: [PATCH] Revert "Remove non-standard `contextMenus.create`" This reverts commit ab19d0db172e5b1df7fcb2820e0dcd4a5d58c3c4. That was introduced in PR #26 as an alternative approach to #27. However with the more consistent solution of #27, `contextMenus.create` should be promisified, in order to ensure a consistent API (so it returns a Promise, like everything else). --- chrome-extension-async.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome-extension-async.js b/chrome-extension-async.js index 838e8fb..5e7caae 100644 --- a/chrome-extension-async.js +++ b/chrome-extension-async.js @@ -155,7 +155,7 @@ { n: 'camera', props: knownInContentSetting }, { n: 'unsandboxedPlugins', props: knownInContentSetting }, { n: 'automaticDownloads', props: knownInContentSetting }], - contextMenus: ['update', 'remove', 'removeAll'], /* 'create' omitted intentionally, it does not follow standard asynchronous pattern */ + contextMenus: ['create', 'update', 'remove', 'removeAll'], cookies: ['get', 'getAll', 'set', 'remove', 'getAllCookieStores'], debugger: ['attach', 'detach', 'sendCommand', 'getTargets'], desktopCapture: ['chooseDesktopMedia'],