Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music volume issues #32

Open
Melodeiro opened this issue Feb 12, 2022 · 7 comments
Open

Music volume issues #32

Melodeiro opened this issue Feb 12, 2022 · 7 comments

Comments

@Melodeiro
Copy link

It seems like C:BN does not respect music volume from json, and if you go into the settings, change anything (not even related to volume), the current playing music volume will be overriden by the volume from thettings.

Same thing happen when you just start the game, i guess, because music is loud (if set to 100%), and the next track from playlist will be with the volume from json... until you again change something in game settings.

Just tested with every track set to 100% and ingame music volume at 100, i don't have issues anymore:
image

Btw, not sure why some tracks set to 20% and some to 70%+, most of them are of the same volume:
image
Tracks from that screenshot has 20 and 70 volume accordingly, but as you can see, second one has even higher peaks. I might guess, why did that happen: the person, who adjusted those volumes either forgot to change json volume settings after sound file normalization, or just adjusted them by just using poorly configured sound equipment. The second one is very loud on the lower frequencies (or just of a poor quality/mastering), that way it might sound less louder, on the systems with quiet low frequencies

Anyway, i'm not sure if overriding volume issue is a problem from Bright Nights, maybe we should report it to their github, but also i suggest to change volumes with more respect to their actual loudness, which is always better to get from sound wave visualisation tools, if you have no studio equipment. I recommend Audacity, this one can be used to easily normalize tracks as well. Just Ctrl+A it, and use that feature:
image
Quick tests shows that right now files are already normalized to about from -12 to -14 dB

Thanks for the good sound pack btw!

@Kenan2000
Copy link
Owner

I really appreciate it, but considering that sounds are normalized, not sure how to fix this

@Melodeiro
Copy link
Author

I really appreciate it, but considering that sounds are normalized, not sure how to fix this

Let's say, tracks are normalized (files), but their settings (json) "unnormalized" them

@Kenan2000 Kenan2000 reopened this Mar 26, 2022
@Kenan2000
Copy link
Owner

Let's say, tracks are normalized (files), but their settings (json) "unnormalized" them

Alright, reopened this issue, I appreciate you clarifying this, so music json volume needs to be edited? Can you share your proposed values for volume of each music file or it requires some testing as well?

@Melodeiro
Copy link
Author

Melodeiro commented Mar 27, 2022

Since there is a BN bug which i described in a first message, track settings should be the same as ingame music volume. I played with 100 for a month or so, but you might want to reduce overall volume in windows mixer, or wait till a bug is fixed
https://gist.github.com/Melodeiro/e2f177d9c241944c39f96e67f5849691

Opened an issue: cataclysmbnteam/Cataclysm-BN#1418 Thought about contributing it myself, but lately have not very much time

@leoCottret
Copy link

Should be fixed by cataclysmbnteam/Cataclysm-BN#1434
No problems on my end too.

@Melodeiro
Copy link
Author

Yes, but tracks still have weird sound volumes. For me it's much better when everything in tracklist is set to 100. Is it me, or does someone else think it's better?

@leoCottret
Copy link

leoCottret commented Oct 13, 2022

Nevermind, there are still some problems (although a bit different).
The music volume can be changed in game but the ambient volume can't, you need to reload the save.
I openned an issue cataclysmbnteam/Cataclysm-BN#2019

About the music sound problem @Kenan2000, I think @Melodeiro just want the musicset.json to be changed like this:

[
  {
    "type": "playlist",
    "playlists": [
      {
        "id": "title",
        "shuffle": true,
        "files": [
          { "file": "music/Blooming_Romance.ogg", "volume": 100 },
          { "file": "music/Fairytale.ogg", "volume": 100 },
          { "file": "music/Goodbye.ogg", "volume": 100 },
          { "file": "music/Homesickness.ogg", "volume": 100 },
          { "file": "music/Hope.ogg", "volume": 100 },
          { "file": "music/Life.ogg", "volume": 100 },
          { "file": "music/Lost_In_Time.ogg", "volume": 100 },
          { "file": "music/Memories.ogg", "volume": 100 },
          { "file": "music/Night_Song.ogg", "volume": 100 },
          { "file": "music/November.ogg", "volume": 100 },
          { "file": "music/Save_Me.ogg", "volume": 100 },
          { "file": "music/See_You_Again.ogg", "volume": 100 },
          { "file": "music/Solitude.ogg", "volume": 100 },
          { "file": "music/Walk_In_The_Rain.ogg", "volume": 100 },
          { "file": "music/Willing_To_Love.ogg", "volume": 100 },
          { "file": "music/i_did_it_for_you.ogg", "volume": 100 },
          { "file": "music/i_pray_for_it.ogg", "volume": 100 },
          { "file": "music/bathwater_submerged_mix.ogg", "volume": 100 },
          { "file": "music/blurred_photo_of_a_woman.ogg", "volume": 100 },
          { "file": "music/its_above_me_now.ogg", "volume": 100 },
          { "file": "music/raindetect.ogg", "volume": 100 },
          { "file": "music/toxin.ogg", "volume": 100 },
          { "file": "music/HR2977.ogg", "volume": 100 },
          { "file": "music/nobody_can_hear_you.ogg", "volume": 100 },
          { "file": "music/they_wont_notice.ogg", "volume": 100 },
          { "file": "music/honeytea.ogg", "volume": 100 },
          { "file": "music/a_common_atrocity.ogg", "volume": 100 },
          { "file": "music/im_in_a_blanket.ogg", "volume": 100 },
          { "file": "music/angelspit_fearmonger.ogg", "volume": 100 },
          { "file": "music/AV_Lightinthedark.ogg", "volume": 100 },
          { "file": "music/carpenterbrut_bloodmachines.ogg", "volume": 100 },
          { "file": "music/carpenterbrut_turbokiller", "volume": 100 },
          { "file": "music/chewbubblegumkickass.ogg", "volume": 100 },
          { "file": "music/crthead_ttp.ogg", "volume": 100 },
          { "file": "music/dd_instrumentsofretribution.ogg", "volume": 100 },
          { "file": "music/deepred.ogg", "volume": 100 },
          { "file": "music/dwtd_andromeda.ogg", "volume": 100 },
          { "file": "music/dwtd_eyesofmadness.ogg", "volume": 100 },
          { "file": "music/dwtd_stitch.ogg", "volume": 100 },
          { "file": "music/encounter_behemothiv.ogg", "volume": 100 },
          { "file": "music/ff_midnighthaze.ogg", "volume": 100 },
          { "file": "music/gw_coldwar_ncrlr.ogg", "volume": 100 },
          { "file": "music/hangemall.ogg", "volume": 100 },
          { "file": "music/kp_nightritual-redherring.ogg", "volume": 100 },
          { "file": "music/kp_resolution.ogg", "volume": 100 },
          { "file": "music/LAZERPUNK_POWER.ogg", "volume": 100 },
          { "file": "music/NN_exhdivnity.ogg", "volume": 100 },
          { "file": "music/raydar_fullmoon.ogg", "volume": 100 },
          { "file": "music/raydar_satan.ogg", "volume": 100 },
          { "file": "music/raydar_thegathering.ogg", "volume": 100 },
          { "file": "music/rollermobster.ogg", "volume": 100 },
          { "file": "music/tn_rasengan.ogg", "volume": 100 },
          { "file": "music/tonebox_implosion.ogg", "volume": 100 },
          { "file": "music/toxxify_eternalsacrfiice.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber1.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber2.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber3.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber4.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber5.ogg", "volume": 100 },
          { "file": "music/azathoth_cryochamber6.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber1.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber2.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber3.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber4.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber5.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber6.ogg", "volume": 100 },
          { "file": "music/yig_cryochamber7.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber1.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber2.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber3.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber4.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber5.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber6.ogg", "volume": 100 },
          { "file": "music/hastur_cryochamber7.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber1.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber2.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber3.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber4.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber5.ogg", "volume": 100 },
          { "file": "music/yogsothoth_cryochamber6.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo1.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo2.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo3.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo4.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo5.ogg", "volume": 100 },
          { "file": "music/yig_cryochambertwo6.ogg", "volume": 100 }
        ]
      }
    ]
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants