Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch pulse_apparition_time if not a parameter #62

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

Kev1CO
Copy link
Owner

@Kev1CO Kev1CO commented May 27, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for ongoing changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @Kev1CO in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 87.26%. Comparing base (050e41d) to head (f450ac0).
Report is 1 commits behind head on main.

Files Patch % Lines
cocofest/optimization/fes_ocp_dynamics.py 9.09% 10 Missing ⚠️
cocofest/optimization/fes_ocp.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   87.70%   87.26%   -0.45%     
==========================================
  Files          23       23              
  Lines        2099     2104       +5     
==========================================
- Hits         1841     1836       -5     
- Misses        258      268      +10     
Flag Coverage Δ
unittests 87.26% <72.72%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kev1CO Kev1CO merged commit c43ce94 into main May 27, 2024
4 of 7 checks passed
@Kev1CO Kev1CO deleted the pulse_apparition_time branch May 27, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant