Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor image grabbing #62

Open
KevinSchildhorn opened this issue Dec 13, 2024 · 1 comment
Open

refactor image grabbing #62

KevinSchildhorn opened this issue Dec 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@KevinSchildhorn
Copy link
Owner

Image loading was originally developed with individual pulls in mind, however now that coil is added to the project we should re-factor how well grab image data so that it's more streamlined.

@KevinSchildhorn KevinSchildhorn added the enhancement New feature or request label Dec 13, 2024
@KevinSchildhorn KevinSchildhorn self-assigned this Dec 13, 2024
@KevinSchildhorn
Copy link
Owner Author

See notes here

  1. It doesn't make sense in my mind why you can't use SourceFetchResult for both Android and Desktop.
  2. The ImageDirectory doesn't necessarily need the val image: SharedImage?
  3. The Image only needs the path to work, there's no need to add the entire NetworkDirectoryDetails.
  4. There doesn't really seem to be a need to have two fetchers? In theory As long as you have the path to the image then that should be all you need.
  5. There are a lot of UseCases and other classes that could probably be taken out.

@KevinSchildhorn KevinSchildhorn pinned this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant