feat: ui refinement for sapling part

Author: soralit

rust/apps/zcash/src/pczt/parse.rs

@@ -156,11 +156,14 @@ pub fn parse_pczt<P: consensus::Parameters>(
     let total_transfer_value = format_zec_value((total_output_value - total_change_value) as f64);
     let fee_value = format_zec_value((total_input_value - total_output_value) as f64);
 
+    let has_sapling = pczt.sapling().spends().len() > 0 || pczt.sapling().outputs().len() > 0;
+
     Ok(ParsedPczt::new(
         parsed_transparent,
         parsed_orchard,
         total_transfer_value,
         fee_value,
+        has_sapling,
     ))
 }
 
@@ -392,7 +395,7 @@ fn parse_orchard_output<P: consensus::Parameters>(
 
                 Ok(Some(ParsedTo::new(
                     if is_internal {
-                        "wallet-internal".to_string()
+                        "<internal-address>".to_string()
                     } else {
                         user_address.clone().unwrap_or(ua)
                     },

rust/apps/zcash/src/pczt/structs.rs

@@ -5,7 +5,8 @@ impl_public_struct!(ParsedPczt {
     transparent: Option<ParsedTransparent>,
     orchard: Option<ParsedOrchard>,
     total_transfer_value: String,
-    fee_value: String
+    fee_value: String,
+    has_sapling: bool
 });
 
 impl_public_struct!(ParsedTransparent {

rust/rust_c/src/zcash/src/structs.rs

@@ -21,6 +21,7 @@ pub struct DisplayPczt {
     pub orchard: Ptr<DisplayOrchard>,
     pub total_transfer_value: PtrString,
     pub fee_value: PtrString,
+    pub has_sapling: bool,
 }
 
 impl From<&ParsedPczt> for DisplayPczt {
@@ -36,6 +37,7 @@ impl From<&ParsedPczt> for DisplayPczt {
                 .unwrap_or(null_mut()),
             total_transfer_value: convert_c_char(pczt.get_total_transfer_value()),
             fee_value: convert_c_char(pczt.get_fee_value()),
+            has_sapling: pczt.get_has_sapling(),
         }
     }
 }

src/ui/gui_chain/others/gui_zcash.c

@@ -59,7 +59,13 @@ void GuiZcashOverview(lv_obj_t *parent, void *totalData) {
     lv_obj_add_flag(container, LV_OBJ_FLAG_SCROLLABLE);
     lv_obj_add_flag(container, LV_OBJ_FLAG_CLICKABLE);
 
-    lv_obj_t* last_view = CreateTransactionItemView(container, _("Amount"), g_zcashData->total_transfer_value, NULL);
+    lv_obj_t* last_view = NULL;
+
+    if(g_zcashData->has_sapling) {
+        last_view = CreateTransactionItemView(container, _("Warning"), _("This transaction contains Sapling spends or outputs. Keystone does not support Sapling spend signing and output checking. Please take care of the potential risks."), last_view);
+    }
+
+    last_view = CreateTransactionItemView(container, _("Amount"), g_zcashData->total_transfer_value, last_view);
     last_view = CreateTransactionItemView(container, _("Fee"), g_zcashData->fee_value, last_view);
 
     if(g_zcashData->transparent != NULL) {