Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Prompt is not collecting any message #103

Open
6 tasks
taOsemc opened this issue Oct 6, 2020 · 3 comments
Open
6 tasks

BUG: Prompt is not collecting any message #103

taOsemc opened this issue Oct 6, 2020 · 3 comments

Comments

@taOsemc
Copy link
Contributor

taOsemc commented Oct 6, 2020

BUG REPORT

Overview

Prompt is not collecting any message.

Description

Issue state:

  • I know how to fix this and I will open a PR to do so
  • [ X ] I am just reporting the issue

Details:
This issue is about:

  • Typings
  • Documentation
  • [ X ] Bug in existing feature
  • Missing feature / breaking change
  • API / library update
  • None of the above (don't know what the issue is about)

Additional information:

  • Node.js version: V12.18
  • AxonCore version: 2.1
  • Library used: (discordjs)
@taOsemc taOsemc changed the title BUG: BUG: Prompt is not collecting any message Oct 6, 2020
@Khaaz Khaaz added the t: bug label Oct 6, 2020
@Khaaz
Copy link
Owner

Khaaz commented Oct 6, 2020

Thanks for the report. As discussed in discord, this is because Prompt has not been switched to AxonCore Collectors. That means it won't work with djs.

This will be fixed in a future commit:

  • switching Prompt to AxonCore Collector for greatly increased performances
  • lib-agnostic design for Prompt

⚠️ Technical warning:
API may change slightly for Prompt. Typically, we will need to instantiate a Prompt with a MessageCollector in param.

@taOsemc
Copy link
Contributor Author

taOsemc commented Oct 12, 2020

Should be fixed: c8dfdf3

@Khaaz
Copy link
Owner

Khaaz commented Oct 14, 2020

Temporary fixed in 320a060
Prompt will be refactored to use MessageCollector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants