Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dos2unix tool for the SPIR-V workflow #38

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Naghasan
Copy link
Member

The SPIR-V specs and extension workflow uses the tools, adding this to the base image so it is usable by the group.

@Naghasan
Copy link
Member Author

@oddhack / @rpavlik I'm not sure who owns the repo, could I have some eyes on this PR ? Thanks

@oddhack oddhack merged commit cf1f604 into KhronosGroup:main Mar 27, 2024
2 checks passed
@oddhack
Copy link
Collaborator

oddhack commented Mar 27, 2024

@oddhack / @rpavlik I'm not sure who owns the repo, could I have some eyes on this PR ? Thanks

You should be able to run the image from dockerhub now. Since there are varied weird caching issues we've encountered inside and outside CI that make it hard to say just which version you'll get when invoking the 'asciidoctor-spec' image by name, I've found the most reliable way is to include the SHA, e.g.

docker run {args} khronosgroup/docker-images:asciidoctor-spec@sha256:fb9a87a8a8a921820b9cae6c05fa1c12aa52beef485485d00e6e99f1e8148baf /bin/bash

@Naghasan
Copy link
Member Author

Thanks Jon

@Naghasan Naghasan deleted the add-dos2unix branch March 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants